Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore chainload check. #67

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Restore chainload check. #67

merged 1 commit into from
Dec 10, 2023

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure vcpkg chainload file is respected for cross-compile builds.

Technical Details

  • Set VCPKG_ROOT only if chainload variable isn't already populated, indicating CMake has been previously configured with vcpkg.

Test Results

  • Built successfully in Windows and locally.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner December 10, 2023 18:39
@abeltrano abeltrano merged commit 32e5f41 into develop Dec 10, 2023
@abeltrano abeltrano deleted the vcpkgportv2 branch December 10, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano