-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub workflow to build repository using Docker image #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeltrano
force-pushed
the
dockerbuildgithub
branch
2 times, most recently
from
December 7, 2023 08:32
0a4f209
to
48ca894
Compare
abeltrano
force-pushed
the
dockerbuildgithub
branch
from
December 7, 2023 18:54
cbb743f
to
39a97cb
Compare
abeltrano
changed the title
Add workflow to build repository using Docker image
Add GitHub workflow to build repository using Docker image
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Technical Details
build-with-docker.yml
.build.yml
.netremote
docker image tonetremote-build
and addentrypoint-build.sh
script to perform the build.hostap
project dependencies intonetremote-build
Docker image since they're needed for the core build and not WSL2 kernel rebuild.vcpkg
binary caching in the Docker image.Test Results
Reviewer Focus
Future Work
vcpkg.json
copy in thenetremote-dev
Dockerfile context is identical to the one in the root of the project (De-duplicate vcpkg.json copies #58)Checklist
all
compiles cleanly.