Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow to build repository using Docker image #54

Merged
merged 40 commits into from
Dec 7, 2023

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Dec 6, 2023

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow the repository to be built with GitHub.

Technical Details

  • Add docker build action in build-with-docker.yml.
  • Add build workflow which uses the docker build action, build.yml.
  • Rename netremote docker image to netremote-build and add entrypoint-build.sh script to perform the build.
  • Move hostap project dependencies into netremote-build Docker image since they're needed for the core build and not WSL2 kernel rebuild.
  • Make use of vcpkg binary caching in the Docker image.
  • Add CMake presets for CI/CD and release builds.

Test Results

  • Built repository using new workflow run and validated it succeeded.

Reviewer Focus

  • None

Future Work

  • Leverage the build workflow to perform CodeQL analysis.
  • Publish build artifacts as part of an official release process.
  • De-duplicate or at least validate that the vcpkg.json copy in the netremote-dev Dockerfile context is identical to the one in the root of the project (De-duplicate vcpkg.json copies #58)

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano closed this Dec 6, 2023
@abeltrano abeltrano reopened this Dec 6, 2023
@abeltrano abeltrano closed this Dec 6, 2023
@abeltrano abeltrano reopened this Dec 6, 2023
@abeltrano abeltrano force-pushed the dockerbuildgithub branch 2 times, most recently from 0a4f209 to 48ca894 Compare December 7, 2023 08:32
@abeltrano abeltrano changed the title Add workflow to build repository using Docker image Add GitHub workflow to build repository using Docker image Dec 7, 2023
@abeltrano abeltrano marked this pull request as ready for review December 7, 2023 20:18
@abeltrano abeltrano requested a review from a team as a code owner December 7, 2023 20:18
@abeltrano abeltrano merged commit c2cdb98 into develop Dec 7, 2023
2 checks passed
@abeltrano abeltrano deleted the dockerbuildgithub branch December 7, 2023 20:47
@abeltrano abeltrano mentioned this pull request Dec 7, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant