Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server tests. #46

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Add server tests. #46

merged 3 commits into from
Dec 1, 2023

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Enable unit testing of server component.

Technical Details

  • Add unit tests for the server.
  • Stop server automatically on destruction.
  • Make common server-related data like the address and test connection timeout shared.

Test Results

  • All unit tests pass.

Reviewer Focus

None

Future Work

None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner December 1, 2023 21:30
@abeltrano abeltrano merged commit b81916c into develop Dec 1, 2023
2 of 3 checks passed
@abeltrano abeltrano deleted the servertest branch December 1, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano