Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server improvements #44

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Server improvements #44

merged 7 commits into from
Dec 1, 2023

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Dec 1, 2023

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure the server processes can be run in the foreground.
  • Ensure the client test validates the connection prior to invoking APIs.
  • Ensure exe names are consistent across OSes.

Technical Details

  • Default server configuration value RunInBackground to false to allow foreground execution.
  • Validate gRPC connection at TEST_CASE scope prior to SECTION's for APIs.
  • Set OUTPUT_NAME property on netremote-server-[OS] exe targets to netremote-server.

Test Results

  • All tests pass.

Reviewer Focus

None

Future Work

Add separate test for gPRC server and move or replicate connection validation from client test to this new test.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner December 1, 2023 16:55
@abeltrano abeltrano merged commit ced847c into develop Dec 1, 2023
2 checks passed
@abeltrano abeltrano deleted the servertest branch December 1, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant