Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows server implementation #43

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Add Windows server implementation #43

merged 1 commit into from
Dec 1, 2023

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow the gPRC server to run on Windows.

Technical Details

  • Add netremote-server-windows executable hosting the server library.

Test Results

  • Ran the server executable manually and validated the netremote-test-unit tests all passed.

Reviewer Focus

None

Future Work

  • The Windows server executable needs to support daemonization through the -d CLI flag.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner December 1, 2023 16:43
@abeltrano abeltrano merged commit ed4b722 into develop Dec 1, 2023
2 checks passed
@abeltrano abeltrano deleted the serverwin branch December 1, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano