Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new protocol buffer API files to dotnet projects #333

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add new protocol buffer API files to dotnet projects #333

merged 1 commit into from
Aug 5, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure the dotnet project include all of the latest protocol buffer API files.

Technical Details

  • Add new, missing .proto files to the client and server dotnet projects.

Test Results

  • Built each project and entire solution, confirmed build works, server runs, and unit test passes.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner August 5, 2024 15:41
@abeltrano abeltrano merged commit 345bc90 into develop Aug 5, 2024
4 checks passed
@abeltrano abeltrano deleted the dotnetprojfxi branch August 5, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano