Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WifiAccessPointGetAttributes API #326

Merged
merged 11 commits into from
Jul 27, 2024
Merged

Add WifiAccessPointGetAttributes API #326

merged 11 commits into from
Jul 27, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jul 27, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow clients to obtain static attributes associated with an access point. For example, information about an attached attenuator can be encoded expressed as such attributes.

Technical Details

  • Add new API WifiAccessPointGetAttributes.
  • Add new protocol structure Dot11AccessPointAttributes which contains a string key+value map of properties.
  • Add IAccessPoint::GetAttributes interface function.
  • Add basic unit test for WifiAccessPointGetAttributes.
  • Fix casing in ToDot11AuthenticationDot1x adapter helper function.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Consider adding strictly typed RF attenuator information to the AccessPointAttributes structure.
  • Extend WifiAccessPointsEnumerate to provide access point attributes.
  • Add ability to specify attributes in a configuration file provided to the netremote-server binary.
  • Expand unit tests for WifiAccessPointGetAttributes.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner July 27, 2024 06:07
@abeltrano abeltrano merged commit d4dd7f5 into develop Jul 27, 2024
5 checks passed
@abeltrano abeltrano deleted the addapstaticprops branch July 27, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant