Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally include vcpkg port file generation #322

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jul 22, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Avoid calling external processes when building the project as a vcpkg port.

Technical Details

  • Conditionally include vcpkg packaging directory in CMake execution by restoring the previously removed NETREMOTE_BUILD_FOR_VCPKG_PORT variable.

Test Results

  • Built with and without NETREMOTE_VCPKG_BUILD_FOR_PORT defined and verified the port file was and was not generated, respectively.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner July 22, 2024 22:11
@abeltrano abeltrano merged commit ddd989b into develop Jul 22, 2024
5 checks passed
@abeltrano abeltrano deleted the excludeportinport branch July 22, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant