-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Wi-Fi state changes to the audit log #311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbin-phipps
changed the base branch from
develop
to
user/corbinphipps/setup-audit-log
July 12, 2024 16:12
abeltrano
requested changes
Jul 15, 2024
…m::enum_name; Use string_view; Move validation out of try/catch; Use aggregated string for key_mgmt log line; Use .back() = ';'
abeltrano
requested changes
Jul 16, 2024
abeltrano
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
To log Wi-Fi state changes to the audit log. This is done at the neutral
Ieee80211*
layer inAccessPointControllerLinux
for most of theSet*
functions.A debug (
AUDITD
) line is added to log which neutral type values will be attempted to be set, then after the values are set, the updated changes are validated. If successful, an info (AUDITI
) line is added to log the successful changes. If unsuccessful (usually meaning the value retrieved by hostapd is not what was set), then a debug line is added to log the value that was retrieved.Technical Details
AUDITD
andAUDITI
lines inAccessPointControllerLinux.cxx
as described above.Ieee80211*ToString()
functions toIeee80211.*xx
.Test Results
Verified that the following changes show up in the audit log:
Have not been able to verify that setting AKM suites and pairwise cipher suites works.
Tested these changes with
netremote-cli wifi ap-enable wlo1 --phy 3 --akms 1027080 --sae password
,netremote-cli wifi ap-disable wlo1
, andnetremote-cli wifi set-ssid wlo1 netremote2-ap-wlo1
.Reviewer Focus
None.
Future Work
OnWpaEvent
callback).AccessPointManager
).HostapdBssConfiguration
to usestd::vector<WpaCipher
forWpaPairwiseCipher
andRsnPairwiseCipher
. Currently, there is only a singleWpaCipher
for each.Checklist
all
compiles cleanly.