-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup skeleton audit log #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if
/usr/local
is the best place, but omitting that and just using what is returned byGetLogName
doesn't seem to create a log file anywhere.
The log file as currently used, will be created in the current working directory of the binary. This is configurable using the WorkingDirectory=
configuration directive in [Service]
section of the netremote-server
systemd unit file. I'd guess the binary doesn't have permission to write to that directory (/usr/bin
or /usr/local/bin
) since the service is started as a non-root user. So, the fix should be to set WorkingDirectory
to something a regular user can access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if
/usr/local
is the best place, but omitting that and just using what is returned byGetLogName
doesn't seem to create a log file anywhere.
The log file as currently used, will be created in the current working directory of the binary. This is configurable using the
WorkingDirectory=
configuration directive in[Service]
section of thenetremote-server
systemd unit file. I'd guess the binary doesn't have permission to write to that directory (/usr/bin
or/usr/local/bin
) since the service is started as a non-root user. So, the fix should be to setWorkingDirectory
to something a regular user can access, like/var/log
.
Type
Side Effects
Goals
This PR sets up the foundation for the Wi-Fi state audit log.
Technical Details
AUDIT_LOG*
./usr/local/
.Test Results
Verified that the
AUDIT_LOGN
line added toMain
shows up in/usr/local/202407-LogNetRemote-audit.txt
.Reviewer Focus
I'm not sure if
/usr/local
is the best place, but omitting that and just using what is returned byGetLogName
doesn't seem to create a log file anywhere.Future Work
Write Wi-Fi state and events to the audit log.
Checklist
all
compiles cleanly.