Add generic response parsing #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a wide range of changes to improve the functionality and structure of the codebase. The most important changes include adding a new header file for defining a struct representing key-value pairs in the WPA control protocol, rearranging header file inclusion and adding new functions and classes for parsing and handling response payloads.
Main interface changes:
linux/wpa-controller/include/Wpa/WpaKeyValuePair.hxx: Added a new header file defining a struct for key-value pairs in the WPA control protocol.linux/wpa-controller/WpaCommandStatus.cxx: Rearranged header file inclusion, added a new function to create a response parser, and added a new class for parsing the response payload and setting the status state.linux/wpa-controller/Hostapd.cxx: Modified theHostapd::Ping()function and theGetStatus()function to use new classes and functions for handling responses. [1] [2]linux/wpa-controller/WpaCommand.cxx: Added new member functions to theWpaCommandclass for parsing responses.linux/wpa-controller/WpaController.cxx: Modified theWpaController::SendCommandfunction to store the response payload and handle unknown errors.linux/wpa-controller/CMakeLists.txt: Modified theCMakeLists.txtfile to include new source files and rearrange header file inclusion. [1] [2] [3]src/shared/notstd/CMakeLists.txt: Updated the header guard and added a new header file to the list of public headers.linux/wpa-controller/include/Wpa/ProtocolHostapd.hxx: Added a new static member variable to represent a response status property key.linux/wpa-controller/include/Wpa/ProtocolWpa.hxx: Added a new static member variable to represent the key-value delimiter in the WPA control protocol.src/shared/notstd/include/notstd/Exceptions.hxx: Updated the header guard to avoid naming conflicts.tests/unit/linux/wpa-controller/TestHostapd.cxx: Removed unused variable to eliminate unnecessary code.linux/wpa-controller/include/Wpa/WpaController.hxx: Added a new member function and included necessary header files. [1] [2]linux/wpa-controller/include/Wpa/WpaCommandStatus.hxx: Added necessary header files and improved the functionality of the struct. [1] [2]linux/wpa-controller/WpaKeyValuePair.cxx: Added a new utility function to convert an enumeration value to its underlying type.src/shared/notstd/include/notstd/Utility.hxx: Added a new header file containing a utility function for converting enumeration values.linux/wpa-controller/include/Wpa/WpaCommand.hxx: Added necessary header files.linux/wpa-controller/WpaResponseParser.cxx: Added a new source file containing the implementation of a response parser class.linux/wpa-controller/include/Wpa/WpaResponseParser.hxx: Added a new header file containing the declaration of response parser structs.