Make wpa-controller tests deterministic #308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
wpa-controller-test-unit
unit tests from the CMake binary directory root.wpa-controller-test-unit
tests would fail if the control socket directory doesn't exist.Technical Details
hostapd.conf.format.hxx.in
configure file, relocating its contents to a detail namespace inWpaDaemonManager.cxx
. This became possible since the control socket path is no longer directly written to the file at compile time, but at runtime using the previously compile-time initializedProtocolWpa::ControlSocketPath*
members.hostapd
andwpa_supplicant
.wpa_supplicant
configuration file.HostapdBinaryInfo.hxx.in
configure file which is populated with variables describing the hostapd binary directory and daemon executable.Test Results
wpa-controll-test-unit
tests from root of source tree (not binary tree) and verified it worked and all tests passed.Reviewer Focus
Future Work
Checklist
all
compiles cleanly.