Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker image for Ubuntu 24.04 and Clang/LLVM 18 #303

Merged
merged 10 commits into from
Jul 2, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jul 2, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure Docker container works for all uses, including devcontainer-based development environments.

Technical Details

  • Update netremote-build entrypoint to use new CI/CD preset which employs Ubuntu 24.04 noble and LLVM/Clang 18.
  • Add inputs to the build-with-docker GitHub action for specifying CMake presets.

Test Results

  • Built netremote-build and netremote-dev container images:
    • Validated successful builds of the project in each container.
    • Validated devcontainer worked in VSCode.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano marked this pull request as ready for review July 2, 2024 15:14
@abeltrano abeltrano requested a review from a team as a code owner July 2, 2024 15:14
@abeltrano abeltrano merged commit 1022cf1 into develop Jul 2, 2024
4 checks passed
@abeltrano abeltrano deleted the updatedocker branch July 2, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant