Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netplan-based network topology encoding #252

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Add netplan-based network topology encoding #252

merged 7 commits into from
Apr 12, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Automate as much of the required system network configuration as possible.

Technical Details

  • Add configuration for netplan, a network configuration abstraction renderer from Canonical.
    • Add cloud config file 99-disable-network-config.cfg to disable netplan-based cloud network init.
    • Add netplan file 10-network-netremote-all.yaml defining topology for bridging ethernet to wireless clients.
  • Consolidate debug and release hostapd@ systemd service unit template files.
  • Update hostapd-genconfig@ systemd service unit template:
    • To only run when the target hostapd configuration file doesn't already exist.
    • To remove commented lines from the generated configuration file.
  • Update template hostapd configuration file to only enable WPA3 personal (SAE) and include a default bridge configuration consistent with that generated by the netplan.

Test Results

  • Cleaned test system of all installed files, re-built .deb packages, re-installed them, and verified all desired configuration was as expected.

Reviewer Focus

  • None

Future Work

  • Documentation for using the netplan files needs to be added, specifically, where the files need to be copied and how to generate and apply the configuration files for/from the netplan.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner April 12, 2024 20:42
@abeltrano abeltrano merged commit 0c1d502 into develop Apr 12, 2024
3 of 5 checks passed
@abeltrano abeltrano deleted the netplan branch April 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant