Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept SAE password ids and peer mac addresses in CLI #249

Merged
merged 10 commits into from
Apr 3, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Apr 2, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow SAE password ids and peer mac addresses to be configured via CLI.

Technical Details

  • Move strings library to new CMake template.
  • Add common helper function to convert a hex-encoded string to a container of uint8_t.
  • Add parsing logic for SAE password id and peer mac address, replacing the single std::string with std::tuple<std::string, std::optional<std::string>,std::optional<std::string>>.
  • Add helper function to parse a Ieee80211MacAddress from a string.
  • Add checks in API impl for psk passphrase lengths.

Test Results

  • All unit tests pass.
  • Converted arguments for SAE passwords manually confirmed using a debugger.

Reviewer Focus

  • None

Future Work

  • Update labels for CLI options as the current, default ones aren't helpful.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner April 2, 2024 22:17
@abeltrano abeltrano merged commit 9cb5555 into develop Apr 3, 2024
5 checks passed
@abeltrano abeltrano deleted the authdatasaeopts branch April 3, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant