Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic WpaController unit tests for PSK #247

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Add basic WpaController unit tests for PSK #247

merged 2 commits into from
Apr 2, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure the use of PSK-based authentication data with Hostapd is tested.

Technical Details

  • Remove redundant call to Reload in Hostapd::SetPreSharedKey.
  • Add basic unit tests.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Additional high-layer tests need to be added for PSK, including checks for invalid characters.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner April 2, 2024 03:45
@abeltrano abeltrano merged commit 2b8d4b7 into develop Apr 2, 2024
5 checks passed
@abeltrano abeltrano deleted the psktests branch April 2, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano