Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure 6GHz bands can be configured #244

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Ensure 6GHz bands can be configured #244

merged 4 commits into from
Mar 29, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure 6GHz bands are enabled when requested. This band requires protected management frames (PMF) and this was not being set in the lower hostapd layer.

Technical Details

  • Add ManagementFrameProtection enumeration for hostapd.
  • Extend AccessPointControllerLinux::SetFrequencyBands to set the ieee80211w management frames property to ManagementFrameProtection::Required.
  • Move hw_mode property value helper to ProtocolHostapd with other related ones.

Test Results

  • All unit tests pass.
  • Verified out-of-band with hostapd_cli that 6GHz band is enabled following enabling it using the cli.

Reviewer Focus

  • None

Future Work

  • Additional 6GHz related features may need additional changes. These will be determined as needed.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 29, 2024 14:04
@abeltrano abeltrano merged commit 61e7ff9 into develop Mar 29, 2024
5 checks passed
@abeltrano abeltrano deleted the 6ghzfixes branch March 29, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant