Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuring SAE passwords in hostapd layer #242

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Enable SAE-based authentication data to be set from the API layer. The upper layers have the bits needs, but the lower layers (WpaController) need to implement the corresponding interface functions to light the functionality up.

Technical Details

*Add IHostapd::SetSaePasswords and IHostapd::AddSaePassword for setting all and adding individual SAE passwords respectively with hostapd.

  • Call Hostapd::SetSaePasswords from AccessPointControllerLinux::SetAuthenticationData.
  • Update test-cased hostapd.conf file to use CMake install directories instead of being hard-coded.
  • Add SAE auth data unit tests.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 28, 2024 18:43
@abeltrano abeltrano merged commit 4c1d720 into develop Mar 28, 2024
3 of 4 checks passed
@abeltrano abeltrano deleted the hapdsetauthdata branch March 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant