Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow settings AKMs from WifiAccessPointEnable API #240

Merged
merged 7 commits into from
Mar 25, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure AKMs can be set when enabling an access point.

Technical Details

  • Add Pasn AKM type, per 802.11 spec.
  • Add AKM suites to Dot11AccessPointConfiguration.
  • Add WifiAccessPointSetAkmSuitesImpl to service implementation, and invoke it from WifiAccessPointEnable top-level API.
  • Enable use of default server address+port Make -s, --server cli option.
  • Add single-letter cli aliases for authentication algorithms (o-> open system, s-> shared).
  • Add Ieee80211 <-> Dot11 adaption helpers.

Test Results

  • All unit tests pass.
  • Manual invocation of cli tool shows success and out-of-band validation with hostapd_cli indicates the requested changes were made.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 25, 2024 17:03
@abeltrano abeltrano merged commit 5e322c9 into develop Mar 25, 2024
5 checks passed
@abeltrano abeltrano deleted the apenablesetakms branch March 25, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant