Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nla_parse() stack overflow fixes #228

Merged
merged 2 commits into from
Mar 16, 2024
Merged

nla_parse() stack overflow fixes #228

merged 2 commits into from
Mar 16, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure no stack overflows occur.

Technical Details

  • Some uses of nla_parse were not updated when originally fixed in Fix some memory access issues #221. Fix those off-by-1 instances here.
  • Add missing --id option for netremote-cli command ap-enable.

Test Results

  • Ran netremote-server locally and then netremote-cli wifi enumaps and verified an ASAN-induced crash no longer occurs.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 16, 2024 14:32
@abeltrano abeltrano merged commit ccc641d into develop Mar 16, 2024
2 of 3 checks passed
@abeltrano abeltrano changed the title Nlaparsefixes nla_parse() stack overflow fixes Mar 16, 2024
@abeltrano abeltrano deleted the nlaparsefixes branch March 19, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant