Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands to enable and disable APs from netremote-cli #227

Merged
merged 5 commits into from
Mar 16, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow access points to be enabled and disabled from the command line tool.
  • Allow end-to-end functionality to be incorporated into functional tests.

Technical Details

  • Add commands ap-enable and ap-disable to the netremote-cli tool.
  • Add Ieee80211AccessPointConfiguration structure corresponding to dot11 equivalent, use for CLI input to the API.
  • Add helper adaption functions for converting between Ieee80211* types in Ieee80211AccessPointConfiguration to those in Dot11AccessPointConfiguration.
  • Link wifi-core and wifi-core-adapter-dot11 libraries to netremote-cli library.
  • Implement access point configuration enforcement in WifiAccessPointEnable API using above implementation bits.

Test Results

  • All unit tests pass.
  • As-hoc testing still in progress.

Reviewer Focus

  • None

Future Work

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 16, 2024 04:09
@abeltrano abeltrano merged commit 8e98c96 into develop Mar 16, 2024
5 checks passed
@abeltrano abeltrano deleted the clienable branch March 16, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant