Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure pairwise ciphers from AccessPointEnable API #226

Merged
merged 8 commits into from
Mar 15, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow configuring pairwise ciphers for an access point.

Technical Details

  • Add IAccessPointController::SetPairwiseCipherSuites and implementation in AccessPointControllerLinux.
  • Add adapters for converting to/from Ieee80211/Wpa security protocols and ciphers.
  • Add Unknown field to WpaSecurityProtocol enumeration.
  • Remove Wapi and Osen field values from WpaSecurityProtocol as they won't be used.
  • Add Unknown field to WpaCipher enumeration.
  • Rename WpaProtocol to WpaSecurityProtocol for consistency with nomenclature throughout the stack.
  • Fix off-by-1 error in operation name calculation expression.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 15, 2024 18:01
@abeltrano abeltrano merged commit 221dc50 into develop Mar 15, 2024
5 checks passed
@abeltrano abeltrano deleted the apctrlsetciphers branch March 15, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant