Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up setting authentication algorithms in WifiAccessPointEnable API #222

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure authentication algorithms can be set.

Technical Details

  • Add explicit source file for IEEE 802.11 <-> WPA conversion utilities and move existing ones here.
  • Add IAccessPointController::SetAuthenticationAlgorithms and implementation in AccessPointControllerLinux.
  • Add Invalid sentinel value to WpaAuthenticationAlgorithms.
  • Add NetRemoteService helper to set authentication algorithms.
  • Replace usage of std::ranges::find with more concise std::ranges::contains from C++23.
  • Update WifiAccessPointEnable via WifiAccessPointEnableImpl to set authentication algorithms.
  • Change Dot11AccessPointConfiguration::AuthenticationAlgorithm field to be a repeated field instead of a single member since multiple algorithms at supported simultaneously, and rename to AuthenticationAlgorithms.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Expand netremote_cli to enable and disable access points.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 14, 2024 15:47
@abeltrano abeltrano merged commit e6ff994 into develop Mar 14, 2024
5 checks passed
@abeltrano abeltrano deleted the apcontrolauth branch March 14, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant