Reduce test default log verbosity from verbose to debug #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Technical Details
plog::verbose
severity is the maximum that can be used and is now by convention, limited to wildly detailed information such as hex dumps of messages or other extremely verbose tracing information. As such, reduce the default log severity of all of the unit tests fromplog::verbose
toplog::debug
.ReadDone
,WriteDone
,NextWrite
) fromplog::verbose
toplog::debug
as these were generating a lot of noise in the unit tests and were not necessary to be shown by default. Added a wrapper structureFunctionTraceVerbose
for these more detailed invocations.Test Results
Reviewer Focus
Future Work
Checklist
all
compiles cleanly.