Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce test default log verbosity from verbose to debug #220

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Prevent ultra-verbose messages from appearing in test logs by default.

Technical Details

  • The plog::verbose severity is the maximum that can be used and is now by convention, limited to wildly detailed information such as hex dumps of messages or other extremely verbose tracing information. As such, reduce the default log severity of all of the unit tests from plog::verbose to plog::debug.
  • Drop the severity from some data streaming internal operations (eg. ReadDone, WriteDone, NextWrite) from plog::verbose to plog::debug as these were generating a lot of noise in the unit tests and were not necessary to be shown by default. Added a wrapper structure FunctionTraceVerbose for these more detailed invocations.

Test Results

  • Re-ran unit tests and validated much fewer messages were printed.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 13, 2024 20:09
@abeltrano abeltrano changed the title Reduce default log verbosity from verbose to debug Reduce test default log verbosity from verbose to debug Mar 13, 2024
@abeltrano abeltrano merged commit d9def6b into develop Mar 13, 2024
3 of 4 checks passed
@abeltrano abeltrano deleted the streamopsverbose branch March 13, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant