Eliminate unnecessary argument from FunctionTracer and derived classes #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Technical Details
logSeverityExit
argument in theFunctionTracer
constructor didn't make a lot of sense since it would be unusual for callers to want to use a different exit log severity from the enter log severity when the object is first created. Thus, thelogSeverityExit
argument is removed (including from all derived classes), and thelogSeverityStart
argument is renamed tologSeverity
, and its value used for both function enter and exit traces.Test Results
Reviewer Focus
Future Work
Checklist
all
compiles cleanly.