Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unnecessary argument from FunctionTracer and derived classes #219

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Reduce the number of arguments needed when customizing function tracing.

Technical Details

  • The logSeverityExit argument in the FunctionTracer constructor didn't make a lot of sense since it would be unusual for callers to want to use a different exit log severity from the enter log severity when the object is first created. Thus, the logSeverityExit argument is removed (including from all derived classes), and the logSeverityStart argument is renamed to logSeverity, and its value used for both function enter and exit traces.

Test Results

  • Ran unit tests and ensured the same log verbosity prior to this change was maintained.

Reviewer Focus

  • Consider whether the assumption made above

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 13, 2024 19:53
@abeltrano abeltrano merged commit 0e7d9c2 into develop Mar 13, 2024
2 checks passed
@abeltrano abeltrano deleted the reducestreamverbosity branch March 13, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant