Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IHostapd interface to replace bool returns with exceptions and direct return values #214

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Enable IHostapd consumers to apply consistent calling and error checking.

Technical Details

  • Change the following functions to throw exceptions instead of returning bool:
    • Enable, Disable, Terminate, Ping, Reload, SetProperty, SetSsid, SetWpaProtocols, SetKeyManagement.
  • Change GetProperty return type from bool to std::string, which captures the property value.
    • Replace bool returns with HostapdException.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 12, 2024 21:27
@abeltrano abeltrano merged commit 2a2c149 into develop Mar 12, 2024
5 checks passed
@abeltrano abeltrano deleted the hostapdexceptall branch March 12, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant