Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement configuration of hostapd wpa protocol and key management #213

Merged
merged 20 commits into from
Mar 12, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow configuration of AP protocol selection and key management.

Technical Details

  • Enable 802.11r-2008 for AP mode in hostapd build.
  • Replace bool with EnforceConfigurationChange enumeration.
    • Sub this into SetProtocol, SetSssid, and newly added SetWpaProtocol and SetWpaKeyManagement functions.
    • Replace explicit reload for higher layer functionality with EnforceConfigurationChange::Now value.
  • Add WpaProtocol, WpaCipher, WpaAlgorithm, and WpaKeyManagement enumerations to match the hostapd control interface expected values for wpa_key_mgmt, wpa, wpa_pairwise, rsn_pairwise and group_cipher settings.
  • Add IHostapd::SetWpaProtocols function with implementation and unit tests.
  • Add IHostapd::SetWpaKeyManagements function with implementation and unit tests.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • The newly added functionality needs to be plumbed up through the stack, in particualr, into IAccessPointController and AccessPointControllerLinux.
  • Add functionality to set ciphers.
  • Add functionality to set key material.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 12, 2024 19:42
@abeltrano abeltrano merged commit 87b0285 into develop Mar 12, 2024
5 checks passed
@abeltrano abeltrano deleted the hapdauth branch March 12, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant