Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine WifiAccessPointSetFrequencyBands into top-level and implementation functions #201

Merged
merged 5 commits into from
Mar 2, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Mar 1, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow the frequency bands type of an access point to be set from any API, not just WifiAccessPointSetFrequencyBands . This is primarily to allow setting the frequency bands consistently, including from other APIs like WifiAcccessPointEnable.

Technical Details

  • Move most functionality from WifiAccessPointSetFrequencyBands to WifiAccessPointSetFrequencyBandsImpl.
  • Add ToDot11FrequencyBands adapter for safely converting from loosely-typed frequencybands() member of WifiAccessPointSetFrequencyBandsRequest to strongly-typed version to workaround protobuf deficiency for repeated enum fields.
  • Update const correctness of helper function.
  • Add skeleton for WifiAccessPointEnable.
  • Add extra tests for WifiAccessPointEnable matching the existing skeleton code.
  • Remove extra validation function.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Make use of WifiAccessPointSetFrequencyBands in WifiAccessPointEnable.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 1, 2024 23:54
@abeltrano abeltrano merged commit faba955 into develop Mar 2, 2024
5 checks passed
@abeltrano abeltrano deleted the setfreqbandsimpl branch March 2, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant