Refine WifiAccessPointSetFrequencyBands into top-level and implementation functions #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
WifiAccessPointSetFrequencyBands
. This is primarily to allow setting the frequency bands consistently, including from other APIs likeWifiAcccessPointEnable
.Technical Details
WifiAccessPointSetFrequencyBands
toWifiAccessPointSetFrequencyBandsImpl
.ToDot11FrequencyBands
adapter for safely converting from loosely-typedfrequencybands()
member ofWifiAccessPointSetFrequencyBandsRequest
to strongly-typed version to workaround protobuf deficiency for repeated enum fields.WifiAccessPointEnable
.WifiAccessPointEnable
matching the existing skeleton code.Test Results
Reviewer Focus
Future Work
WifiAccessPointSetFrequencyBands
inWifiAccessPointEnable
.Checklist
all
compiles cleanly.