-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataStreamDownload API #198
Conversation
…acing Add basic API trace
…-memory-management Use smart pointers for memory management
…-api Add initial DataStreamDownload API implementation
…-improvements DataStreamDownload API improvements
…le concurrency on server side)
…ownload-stream Add continuous download stream unit test
Merge develop into feature/dataStreaming
…generator Generate random data and check for DataStreamPattern
…-tracer Use function tracer with debug severity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, other than the Windows build failure. Can you take a look at that?
https://github.com/microsoft/netremote/actions/runs/8107181867/job/22158274829?pr=198
Also, there are some clang-tidy issues I'd like to get resolved before merging to develop. I'll send a PR to feature/dataStreaming
with them, then we can integrate that here.
Looks like |
|
Do we ever need single-bytes? In my experience, using |
Since the data generated is a string, I was created one byte (char) at a time hence the use of |
Clang-tidy fixes for DataStreamDownload API
Type
Side Effects
Goals
This PR adds the
DataStreamDownload
API.Technical Details
DataStreamDownload
API toNetRemoteDataStreamingService.proto
and associated types toNetRemoteDataStream.proto
.NetRemoteDataStreamingService
.DataStreamWriter
implementation of gRPCServerWriteReactor
reactor class toNetRemoteDataStreamingReactors
.TestNetRemoteDataStreamingServiceClient
andTestNetRemoteDataStreamingReactors
.Test Results
All tests pass.
Reviewer Focus
None.
Future Work
None.
Checklist
all
compiles cleanly.