Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AccessPointControllerException #192

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Remove AccessPointControllerException #192

merged 1 commit into from
Feb 29, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Avoid try/catch blocks in API implementation to help avoiding leaking exceptions outside the API boundary.

Technical Details

  • Remove AccessPointControllerException source file.
  • Replace AccessPointControllerException usage with a log error and returning an invalid string.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner February 29, 2024 19:48
@abeltrano abeltrano merged commit fb57826 into develop Feb 29, 2024
5 checks passed
@abeltrano abeltrano deleted the removeapcexcept branch February 29, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano