Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate exceptions from AccessPointControllerLinux::SetProtocol #166

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Feb 23, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure the implementation of IAccessPointController functions do not throw exceptions to allow the API layer to avoid try/catch blocks.

Technical Details

  • Change IAccessPointController::SetProtocol to return AccessPointOperationStatus instead of bool.
  • Update AccessPointControllerLinux::SetProtocol to report errors consistently.

Test Results

  • All unit tests pass.
  • Additional ad-hoc testing in progress.

Reviewer Focus

  • None

Future Work

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner February 23, 2024 21:38
@abeltrano abeltrano merged commit 6b11928 into develop Feb 23, 2024
5 checks passed
@abeltrano abeltrano deleted the excepttostatus branch February 23, 2024 22:05
@abeltrano abeltrano linked an issue Feb 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: API implementations can leak uncaught exceptions
1 participant