Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WifiAccessPointDisable API #163

Merged
merged 10 commits into from
Feb 23, 2024
Merged

Implement WifiAccessPointDisable API #163

merged 10 commits into from
Feb 23, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Feb 23, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow disabling an access point.

Technical Details

  • Introduce operational state AccessPointOperationalState (enabled, disabled) in lower layers instead of broken out enabled/disabled state.
  • Add SetOperationalState to IAccessPointController.
  • Change IAccessPointController::GetIsEnabled to GetOperationalState and update return value from bool to AccessPointOperationStatus, eliminating prior thrown exceptions.
  • Add HandleFailure wrapper overload accepting AccessPointOperationStatusCode instead of direct API type.
  • Implement NetRemoteService::WifiAccessPointDisable with above functionality.
  • Add NetRemoteService::WifiAccessPointDisable unit tests.
  • Fix implicit conversions from int -> bool.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner February 23, 2024 00:09
@abeltrano abeltrano merged commit 65b8b0f into develop Feb 23, 2024
4 checks passed
@abeltrano abeltrano deleted the apdisable branch February 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant