Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some some possible issues identified by clang-tidy #160

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Some some possible issues identified by clang-tidy #160

merged 4 commits into from
Feb 22, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Avoid possible issues due to code smells.

Technical Details

  • Initialize all variables in netlink code.
  • Use plog short macros LOGX instead of LOG_XYZ.
  • Ignore some instances triggering concurrency-mt-unsafe involving std::strerror.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Some other clang-tidy issues related to exceptions will be handled in a separate PR.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner February 22, 2024 17:54
@abeltrano abeltrano merged commit 40fcb9c into develop Feb 22, 2024
3 checks passed
@abeltrano abeltrano deleted the fixnits branch February 22, 2024 17:55
@abeltrano abeltrano mentioned this pull request Feb 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano