Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample usage of proposed data streaming APIs #159

Conversation

corbin-phipps
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

This draft PR shows sample usage of the proposed data streaming APIs in both the server (API implementations) and client (unit tests) sides.

Technical Details

  • Added three new APIs: WifiDataStreamUpload, WifiDataStreamDownload, and WifiDataStreamBidirectional to NetRemoteCallbackService.proto, along with corresponding types in NetRemoteWifi.proto.
  • Added NetRemoteCallbackService with sample implementations of the three APIs.
  • Added TestNetRemoteCallbackServiceClient unit test file with unit tests for all three APIs.

Test Results

All tests pass.

Reviewer Focus

Overall design and usage.

Future Work

Once design is approved, APIs will be fully implemented and cleaned up, along with unit tests.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@corbin-phipps corbin-phipps changed the base branch from develop to feature/dataStreaming February 20, 2024 23:12
@abeltrano abeltrano closed this Jun 28, 2024
@corbin-phipps corbin-phipps deleted the user/corbinphipps/data-stream-prototype branch June 28, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants