Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify running systemd services from development environment #158

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Feb 20, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Simplify running services for built binaries in development environment.

Technical Details

  • Remove *_XTRA_ARGS from ExecStart lines for hostapd and netremote-server.
  • Add systemd service unit template hostapd-genconfig@ that creates a default hostapd configuration file based on the installed example configuration file.
  • Seaprate [email protected] systemd unit into a development version and release version.
  • Add hostapd-genconfig@%i as dependency to development version of [email protected]`.
  • Add file assertions to [email protected] and [email protected] for dependent hostapd configuration files.
  • Rename hostapd.example.conf to hostapd-example.conf for consistency with other conf file naming.

Test Results

  • Cleaned install directory, removed old configuration files, built .deb packages, installed netremote-hostapd_0.0.1_amd64.deb with apt, then disabled and re-enabled the hostapd@wls1 service and verified the default configuration file was created and hostapd started for wls1.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano marked this pull request as ready for review February 21, 2024 20:04
@abeltrano abeltrano requested a review from a team as a code owner February 21, 2024 20:04
@abeltrano abeltrano merged commit 9bc57dc into develop Feb 21, 2024
5 checks passed
@abeltrano abeltrano deleted the removextraargs branch February 21, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant