Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make API failure logging consistent #157

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Make API failure logging consistent #157

merged 2 commits into from
Feb 20, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure failures in APIs have consistent logging.

Technical Details

  • Update HandleFailure helper to accept a configurable return type.
  • Replace local use of handleFailure lambda with helper.

Test Results

  • Unit tests pass.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner February 20, 2024 21:31
@abeltrano abeltrano merged commit fc3b95d into develop Feb 20, 2024
5 checks passed
@abeltrano abeltrano deleted the apistreamline branch February 20, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano