Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Container improvements #15

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Dev Container improvements #15

merged 5 commits into from
Nov 14, 2023

Conversation

abeltrano
Copy link
Contributor

This pull request includes changes to improve the development environment for the netremote project. The most important changes include updating the volumes for the netremote-dev and netremote-dev-hostapd services, and updating the Dockerfile for the netremote-dev image to use a specific version of LLVM.

Development environment improvements:

  • .devcontainer/compose-devcontainer.yaml: Changed volumes for netremote-dev and netremote-dev-hostapd services to mount ../.. directory to /workspaces and create a new volume called workspace mounted to /workspace.
  • .devcontainer/devcontainer.json: Updated devcontainer.json to use a variable for the workspace folder and changed the directory path.

Dockerfile improvements:

  • .docker/netremote-dev/Dockerfile: Updated the Dockerfile for the netremote-dev image to use a specific version of LLVM, remove the wget package, and add the lsb-release package. [1] [2] [3]

Docker Compose improvements:

  • .docker/compose.yaml: Updated the netremote-dev-hostapd service to add security options and remove the context property.

@abeltrano abeltrano requested a review from a team as a code owner November 14, 2023 18:37
@abeltrano abeltrano merged commit 2726a3c into develop Nov 14, 2023
2 checks passed
@abeltrano abeltrano deleted the containerimprovements branch November 14, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant