Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to set Wi-Fi frequency bands #149

Merged
merged 13 commits into from
Feb 7, 2024
Merged

Add API to set Wi-Fi frequency bands #149

merged 13 commits into from
Feb 7, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Feb 7, 2024

Note: most of the work in this PR was done by @corbin-phipps in #121.

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow configuration of Wi-Fi Access Point frequency bands.

Technical Details

  • Add protobuf+grpc API WifiAccessPointSetFrequencyBands.
  • Update WifiAccessPointSetPhyType to return InternalError when unspecified access point operations fail.
  • Make request validation helpers static.

Test Results

  • All unit tests pass on Linux.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner February 7, 2024 17:58
@abeltrano abeltrano merged commit f58704c into develop Feb 7, 2024
4 checks passed
@abeltrano abeltrano deleted the freqbandapi branch February 7, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant