Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize CMake presets #143

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Organize CMake presets #143

merged 9 commits into from
Feb 1, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jan 31, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure CMake presets are consistently named.
  • Ensure CMake presets are consistently styled.
  • Ensure CMake presets can be used for development loop and release cycle.

Technical Details

  • De-duplicate <preset>-base and <preset>, leaving for the latter ones in place for base settings.
  • Group presets for each OS together so they're easier to find.
  • Move compiler options to top-level OS presets.

Test Results

  • Executed CMake configure, build, and install targets for Development and Release targets on Linux.
  • Executed cpack -C <configuration=Debug|RelWithDebInfo> for Development Release targets, and verified the created .deb package had the correct paths and files.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 31, 2024 22:49
@abeltrano abeltrano merged commit 49ebda2 into develop Feb 1, 2024
5 checks passed
@abeltrano abeltrano deleted the presetsconsistent branch February 1, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant