Ensure .deb files are created consistently across all CMake presets #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Technical Details
CPACK_PACKAGING_INSTALL_PREFIX
andCPACK_SET_DESTDIR
intoCMakePresets.json
.dev-packaging-base
andrelease-packaging-base
.libwpa_client.so
instead of relying onTYPE
default.${CMAKE_INSTALL_FULL_RUNSTATEDIR}
with `${CMAKE_INSTALL_RUNSTATEDIR}) for hostapd run state directory staging.release-linux
configure preset toRelease
for consistency.Test Results
cpack -C Debug
with bothDevelopment
andRelease
configure presets, then dumped contents ofnetremote-hostapd_0.0.1_amd64.deb
andnetremote-server_0.0.1_amd64.deb
and ensured contents were identical and contained all expected filesystem location targets:Reviewer Focus
Future Work
Checklist
all
compiles cleanly.