Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers for managing access points for unit tests #136

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow tests to create fake/simulated access points to validate functionality that requires the existence of access points.

Technical Details

  • Add AccessPointManagerTest class which inherits from AccessPointManager but exposes the AddAccessPoint and RemoveAccessPoint functions, allowing tests to add/remove access points at will.
  • Extend AccessPointTest to contain public members tracking configurable properties, including capabilities and enablement status.
  • Update AccessPointControllerTest to take a AccessPointTest and use this instance to implement the IAccessPointController interface, reflecting all of the property values from it.
  • Add documentation to test classes.

Test Results

  • All unit tests pass.

Reviewer Focus

  • Consider whether any additional functionality is needed to use these updated classes now for API validation.

Future Work

  • The test implementations will need to be updated as APIs are implemented and extended.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 26, 2024 18:40
@abeltrano abeltrano mentioned this pull request Jan 26, 2024
10 tasks
@abeltrano abeltrano merged commit 70b8526 into develop Jan 26, 2024
@abeltrano abeltrano deleted the apmanagertest branch January 26, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant