Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script to build mac80211_hwsim kernel module #131

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure the mac80211_hwsim module can be built on newer kernels (5.15.133.1+).

Technical Details

  • Enable CONFIG_WLAN feature in case the default ever changes to be disabled, or, if the running kernel has it disabled.
  • Move kernel and module prep to after kernel configuration is set.

Test Results

  • Rebuilt kernel with script from scratch and verified mac80211_hwsim was build and could be loaded with modprobe.

Reviewer Focus

  • Consider whether there is any configuration where this sequence of build steps would not work.

Future Work

  • Hopefully, none.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 25, 2024 22:59
@abeltrano abeltrano merged commit 4553be0 into develop Jan 25, 2024
1 check failed
@abeltrano abeltrano deleted the fixhwsimbuild branch January 25, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant