Disable file logging by default in Linux server. #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Avoid logging to file when not necessary. Since we're mostly targeting distros with systemd, logging is not needed by default since
stdout
is collected by default and forwarded to the systemd journal, which can then be accessed with standardized tooling (eg.journalctl
) and in mostly arbitrary formats (syslog, json, xml, etc.).Technical Details
--enable-file-logging
, supported by a new fieldNetRemoteServerConfiguration::EnableFileLogging
.Test Results
netremote-server --enable-file-logging <required args>
and verified a log file was produced in the working directory.netremote-server <required args>
and verified no log file was produced in the working directory.Reviewer Focus
Future Work
Checklist
all
compiles cleanly.