Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate AKMs in capabilities portion of WifiEnumerateAccessPoints #126

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure supported AKMs are communicated to API clients via WifiEnumerateAccessPoints

Technical Details

  • Add parsing for NL80211_ATTR_AKM_SUITES in Nl80211Wiphy parsing.
  • Rename Ieee80211AkmSuite::FilsSha284 entry to FilsSha384 (fixing typo).

Test Results

  • All unit tests pass.
  • Ran netremote-cli wifi enumaps with the following output:
shadowfax@mrstux:~/src/microsoft/netremote-cmake/out/build/dev-linux/src/linux/tools/cli/Debug$ ./netremote-cli -s 127.0.0.1 wifi enumaps
Executing command WifiEnumerateAccessPoints
[1] wls1
  Phy Types: B G N AC
  Bands:
    5000MHz
    2400MHz
  Authentication and Key Management (AKM) Suites:
    Reserved0
    8021x
    Psk
    Ft8021x
    FtPsk
    8021xSha256
    PskSha256
    Tdls
    Sae
    FtSae
    ApPeerKey
    8021xSuiteB
    8021xSuiteB192
    Ft8021xSha384
    FilsSha256
    FilsSha384
    FtFilsSha256
    FtFilsSha384
    Owe
    FtPskSha384
    PskSha384
  Cipher Algorithms:
    Wep40
    Wep104
    Tkip
    Ccmp128
    BipCmac128

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 24, 2024 20:52
@abeltrano abeltrano merged commit 9d3de96 into develop Jan 24, 2024
4 checks passed
@abeltrano abeltrano deleted the capsakms branch January 24, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant