Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up lower layers to implement capabilities portion of WifiEnumerateAccessPoints #124

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jan 24, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure most access point capabilities are reported via WifiEnumerateAccessPoints.

Technical Details

  • Rename Ieee80211AccessPointCapabilities::Dot11FrequencyBands field name to FrequencyBands.
  • Add support to create a Nl80211Wiphy from an interface name.
  • Populate Ieee80211AccessPointCapabilities::(Protocols|FrequencyBands|CipherSuites) fields in GetCapabilities() implementation.

Test Results

  • All unit tests pass.
  • Ran netremote-cli wifi enumaps with the following output:
shadowfax@mrstux:~/src/microsoft/netremote-cmake/out/build/dev-linux/src/linux/tools/cli/Debug$ ./netremote-cli -s 127.0.0.1 wifi enumaps
Executing command WifiEnumerateAccessPoints
[1] wlx08beac0696fe
  Phy Types: B G N
  Bands:
    2400MHz
  Authentication Algorithms:
  Cipher Algorithms:
    Wep40
    Wep104
    Tkip
    Ccmp128
    Ccmp256
    Gcmp128
    Gcmp256
    BipCmac128
    BipCmac256
    BipGmac128
    BipGmac256

[2] wls1
  Phy Types: B G N AC
  Bands:
    5000MHz
    2400MHz
  Authentication Algorithms:
  Cipher Algorithms:
    Wep40
    Wep104
    Tkip
    Ccmp128
    BipCmac128

Reviewer Focus

  • None

Future Work

  • The AKMs are not yet populated since parsing code is needed in the Netlink80211Wiphy structure. The nl80211 AKM attributes have a convoluted nesting structure which is deserving of its own PR.
  • Consider moving nl80211 <-> Ieee80211 conversion functions into their own file or library.
  • Consider adjusting middle portions of AccessPoint* hierarchy further to work with IAccessPoint instead of interface names to avoid some duplication of execution.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 24, 2024 16:28
@abeltrano abeltrano merged commit 1cfac50 into develop Jan 24, 2024
4 checks passed
@abeltrano abeltrano deleted the caps2 branch January 24, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant