Update protobuf Wi-Fi API types to match the 802.11 specification #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Technical Details
protocol/protos/NetRemoteWifi.proto
: RenamedAccessPointCapabilities
toDot11AccessPointCapabilities
andAccessPointConfiguration
toDot11AccessPointConfiguration
inWifiEnumerateAccessPointsResultItem
andWifiAccessPointEnableRequest
messages. [1] [2]protocol/protos/WifiCore.proto
: RenamedRadioBand
enum toDot11FrequencyBand
and rearranged its members. Modified theDot11PhyType
enum by reordering its members and adding modulation type aliases. RenamedDot11CipherAlgorithm
enum toDot11CipherSuite
and rearranged its members. RenamedAccessPointConfiguration
,AccessPointCapabilities
, andAccessPointState
messages toDot11AccessPointConfiguration
,Dot11AccessPointCapabilities
, andDot11AccessPointState
, respectively. [1] [2] [3] [4]src/common/service/NetRemoteService.cxx
: Updated several function implementations to use the renamed types and enums, and to handle the reordered enum members. [1] [2] [3] [4] [5]Test Results
Reviewer Focus
Future Work
Dot11AccessPointConfiguration
structure needs to be updated to allow specification of multiple AKMs and cipher suites.Checklist
all
compiles cleanly.