Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf Wi-Fi API types to match the 802.11 specification #123

Merged
merged 12 commits into from
Jan 24, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure the API reflects the architecture and definitions described in the 802.11 (2020) specification.

Technical Details

  • protocol/protos/NetRemoteWifi.proto: Renamed AccessPointCapabilities to Dot11AccessPointCapabilities and AccessPointConfiguration to Dot11AccessPointConfiguration in WifiEnumerateAccessPointsResultItem and WifiAccessPointEnableRequest messages. [1] [2]

  • protocol/protos/WifiCore.proto: Renamed RadioBand enum to Dot11FrequencyBand and rearranged its members. Modified the Dot11PhyType enum by reordering its members and adding modulation type aliases. Renamed Dot11CipherAlgorithm enum to Dot11CipherSuite and rearranged its members. Renamed AccessPointConfiguration, AccessPointCapabilities, and AccessPointState messages to Dot11AccessPointConfiguration, Dot11AccessPointCapabilities, and Dot11AccessPointState, respectively. [1] [2] [3] [4]

  • src/common/service/NetRemoteService.cxx: Updated several function implementations to use the renamed types and enums, and to handle the reordered enum members. [1] [2] [3] [4] [5]

Test Results

  • Compile tested. Despite this being a breaking change, compilation ensures existing (local) code was updated correctly.

Reviewer Focus

  • None

Future Work

  • The Dot11AccessPointConfiguration structure needs to be updated to allow specification of multiple AKMs and cipher suites.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 24, 2024 00:03
@abeltrano abeltrano merged commit c6be09f into develop Jan 24, 2024
4 checks passed
@abeltrano abeltrano deleted the fixwifiauthalgapitype branch January 24, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant