Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept linux-specific factory for AccessPointDiscoveryAgentOperationsNetlink #122

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Relax interface restrictions in implementation, specifically related to the AccessPoint* hierarchy.

Technical Details

  • Change AccessPointDiscoveryAgentOperationsNetlink from accepting the generic IAccessPointFactory to a AccessPointFactoryLinux, which is intended to be the base for all Linux implementations. Use this to allow capturing the ready-made Nl80211Interface which is then passed to the AccessPointLinux instance.
  • Add Linux-specific wifi test helper library.

Test Results

  • All unit tests pass.
  • netremote-cli wifi enumaps works as expected.

Reviewer Focus

  • None

Future Work

  • Make use of the Nl80211Interface to populate access point capabilities in the API.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 22, 2024 23:21
@abeltrano abeltrano merged commit 44eb34d into develop Jan 23, 2024
5 checks passed
@abeltrano abeltrano deleted the apcapimplapi branch January 23, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant