Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate capabilities in WifiEnumerateAccessPoints API #117

Merged
merged 8 commits into from
Jan 20, 2024
Merged

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jan 20, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure access point capabilities can be obtained by clients.

Technical Details

  • Implement conversion functions from the Ieee80211* spec types to the Dot11* API types.
  • Filter out non-AP interfaces when probing using netlink-based ap discovery mechanism.

Test Results

  • Unit tests still need to be authored and carried out.
  • Ran netremote-cli and ensured no crashes occurred. Also attached a debugger to the server side and inspected the fully built protobuf object which appeared to be correct, excepting the known issues (see Future Work section below).

Reviewer Focus

  • Consider whether the mapping from Ieee80211* to Dot11* API types makes sense and/or whether there are cases where the mapping is not 1-1.

Future Work

  • The Dot11AuthenticationAlgorithm protobuf enumeration currently reflects Windows view of 802.11 authentication algorithms, however, it appears more like an 802.11 AKM instead. As such, there is no direct mapping(s) from the Ieee80211AuthenticationAlgorithm enumeration. An API breaking change will be needed to fix this, @corbin-phipps FYI.
  • The netremote-cli tool needs to be updated to display the capabilities information.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 20, 2024 05:25
@abeltrano abeltrano merged commit d16adc4 into develop Jan 20, 2024
5 checks passed
@abeltrano abeltrano deleted the capsimpl branch January 20, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant