Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to check if an access point is enabled #116

Merged
merged 6 commits into from
Jan 20, 2024
Merged

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jan 20, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow populating the WifiEnumerateAccessPointsResultItem::IsEnabled field.

Technical Details

  • Add GetIsEnabled() function to IAccessPointController interface.
  • Implement GetIsEnabled() in existing test class and in AccessPointControllerHostapd.
  • Switch use of WpaController to higher-level Hostapd instance in AccessPointControllerHostapd.
  • Rename AccessPointCapabilities2 to Ieee80211AccessPointCapabilities.
  • Move AccessPointControllerException and HostapdException implementation to own source files.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Existing tests need to be expanded to include the GetIsEnabled API.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano marked this pull request as ready for review January 20, 2024 01:28
@abeltrano abeltrano requested a review from a team as a code owner January 20, 2024 01:28
@abeltrano abeltrano merged commit 43b4f99 into develop Jan 20, 2024
5 checks passed
@abeltrano abeltrano deleted the isenabled branch January 20, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant