Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate access point creation and management #114

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Separate access point creation and management #114

merged 2 commits into from
Jan 18, 2024

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Separate creation and management of access points.

Technical Details

  • Modify AccessPointManager to accept an AccessPointFactory on creation.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Update netremote-server on Linux to provide a factory which creates Linux-specific access points instead of the default/base AccessPoint.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 18, 2024 22:23
@abeltrano abeltrano changed the title Access an Separate access point creation and management Jan 18, 2024
@abeltrano abeltrano merged commit ffeb358 into develop Jan 18, 2024
2 of 4 checks passed
@abeltrano abeltrano deleted the apfactory branch January 18, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano